chore: migrate from structopt to clap #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryota-sakamoto
force-pushed
the
migrate-to-clap
branch
3 times, most recently
from
90e9bfb
to
0bb97e9
Compare
ryota-sakamoto
force-pushed
the
migrate-to-clap
branch
12 times, most recently
from
e70c1be
to
39887eb
Compare
|
This task is blocked by #143. |
ryota-sakamoto
force-pushed
the
migrate-to-clap
branch
6 times, most recently
from
a326a89
to
d9d6815
Compare
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
ryota-sakamoto
force-pushed
the
migrate-to-clap
branch
2 times, most recently
from
6e59e24
to
5ee5ec6
Compare
We need to specify verbatim_doc_comment to show multiple line doc comments for CLI properly. Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
ryota-sakamoto
force-pushed
the
migrate-to-clap
branch
from
5ee5ec6
to
aef0f59
Compare
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
ryota-sakamoto
force-pushed
the
migrate-to-clap
branch
from
aef0f59
to
aef8006
Compare
ryota-sakamoto
changed the title
StoneDot
reviewed
May 20, 2024
Comment on lines
+57
to
58
| #[clap(long)] | ||
| pub third_party_attribution: bool, |
There was a problem hiding this comment.
This and the current implementation do not cause any error even if we execute cargo run -- --shell --third-party-attribution ls. I think the current implementation can be improved using ArgGroup. Should we scope this change into this PR or address in another pull request?
There was a problem hiding this comment.
I will address this point in another pull request.
Signed-off-by: Ryota Sakamoto <skmt@amazon.com>
ryota-sakamoto
force-pushed
the
migrate-to-clap
branch
from
d4c2523
to
0a87300
Compare
StoneDot
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
close #109
Description of changes:
structopt is now in maintenance mode so we need to migrate into clap.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.