chore: Move event marshal/unmarshal code to smithy-swift #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
May 15, 2024
| @@ -115,49 +108,4 @@ abstract class AWSHTTPBindingProtocolGenerator( | |||
| operationMiddleware.appendMiddleware(operation, OperationEndpointResolverMiddleware(ctx)) | |||
| operationMiddleware.appendMiddleware(operation, UserAgentMiddleware(ctx.settings)) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The functions below are moved to parent class HTTPBindingProtocolGenerator in smithy-swift since they are non-AWS specific.
jbelkins
commented
May 15, 2024
| streamingShapes.forEach { streamingMember -> | ||
| messageUnmarshallableGenerator.render(streamingMember) | ||
| } | ||
| } |
There was a problem hiding this comment.
The two generator files below plus the event stream codegen tests and the supporting Smithy test fixture are all moved to smithy-swift.
dayaffe
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
MessageMarshallableGeneratorandMessageUnmarshallableGeneratorfromaws-sdk-swifttosmithy-swiftto support event streaming in non-AWS SDKs.AWSHTTPBindingProtocolGeneratorup to smithy-swift superclassHTTPBindingProtocolGenerator.aws-sdk-swifttosmithy-swift.New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.