Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in the private subnet consideration #31

Closed
wants to merge 1 commit into from

Conversation

badaldavda8
Copy link

This is because for internal ELB auto subnet discovery, both tags are used -
kubernetes.io/role/internal-elb 1
kubernetes.io/cluster/ shared

Since as per code, first kubernetes.io/cluster/ is checked and then kubernetes.io/role/internal-elb is checked.

If kubernetes.io/cluster/ is not mentioned, then internal ELB is created on Public Subnets.
kubernetes/kubernetes#29298 (comment)

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This is because for internal ELB auto subnet discovery, both tags are used -
kubernetes.io/role/internal-elb	1
kubernetes.io/cluster/<cluster-name>	shared

Since as per code, first kubernetes.io/cluster/<cluster-name> is checked and then kubernetes.io/role/internal-elb is checked.

If kubernetes.io/cluster/<cluster-name> is not mentioned, then internal ELB is created on Public Subnets.
kubernetes/kubernetes#29298 (comment)
@M00nF1sh
Copy link
Contributor

M00nF1sh commented Feb 11, 2019

Hi,
I suggest move the "Private Subnet Tagging Requirement for Internal Load Balancers" as a level 3 header under "Subnet Tagging Requirement" instead. Since the "kubernetes.io/cluster/" is already expressed in "Subnet Tagging Requirement".
Also, we can add "Public Subnet Tagging"(kubernetes.io/role/elb) as a sub-item under "Subnet Tagging Requirement" as well.

@nrdlngr
Copy link
Contributor

nrdlngr commented Feb 12, 2019

@M00nF1sh, I agree with your suggestion. I think the public/private considerations should fall under the subnet requirements, since the cluster tag is required for ALL subnets.

nrdlngr added a commit that referenced this pull request Feb 12, 2019
@nrdlngr
Copy link
Contributor

nrdlngr commented Feb 12, 2019

@badaldavda8, thanks for your interest in improving our documentation. I've opted instead to move the load balancer requirements under the subnet tag section, and I've made it more obvious that the cluster tag should apply to all subnets.

@nrdlngr nrdlngr closed this Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants