feat: Support SAM API MergeDefinitions property #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinZZ
force-pushed
the
merge_definitions
branch
from
f91230b
to
6fda642
Compare
xazhao
reviewed
Feb 24, 2023
hoffa
approved these changes
Feb 24, 2023
xazhao
reviewed
Feb 24, 2023
xazhao
approved these changes
Feb 24, 2023
aahung
reviewed
Feb 24, 2023
aahung
reviewed
Feb 24, 2023
hoffa
reviewed
Feb 24, 2023
hoffa
reviewed
Feb 24, 2023
aahung
changed the title
hoffa
reviewed
Feb 24, 2023
aahung
reviewed
Feb 24, 2023
hoffa
reviewed
Feb 24, 2023
aahung
reviewed
Feb 24, 2023
hoffa
reviewed
Feb 24, 2023
GavinZZ
force-pushed
the
merge_definitions
branch
from
97cc676
to
c7c151c
Compare
GavinZZ
force-pushed
the
merge_definitions
branch
from
88474c7
to
2d958f6
Compare
aahung
reviewed
Feb 25, 2023
aahung
reviewed
Feb 25, 2023
aahung
reviewed
Feb 25, 2023
aahung
approved these changes
Feb 25, 2023
This was referenced Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
Allow merging SAM generated definitions into customer defined defnitions.
Description of how you validated changes
all tests passed
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.