Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Athena query policy template #2063

Closed
wants to merge 2 commits into from

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Jun 18, 2021

Issue #, if available:
#1736

Description of changes:
Update AthenaQueryPolicy to include permissions to read table and partition from Glue, and perform necessary S3 operations on pre-defined buckets

Description of how you validated changes:

  • Updated a unit test
  • Deployed a transformed template with a Serverless Function using the policy. The function performs an athena query on specified Athena Table in the policy -> verified the function succeeded when invoked, and returned the query result.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mgrandis mgrandis changed the title Fix athena query policy template fix: Athena query policy template Jun 21, 2021
@hawflau
Copy link
Contributor Author

hawflau commented Aug 17, 2021

We intend to create new policy template for this change instead of updating the existing one. Closing.

@hawflau hawflau closed this Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants