fix: remove scipy from dependency #1518

chuyang-deng · 2020-05-20T23:34:53Z

Issue #, if available:
#1471

Description of changes:
remove scipy from dependency

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to any/all clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-05-20T23:47:41Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-20T23:57:14Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-21T00:09:11Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-21T00:10:48Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu · 2020-05-22T15:38:49Z

src/sagemaker/amazon/common.py

+    try:
+        import scipy
+    except ImportError as e:
+        logging.warning("urllib3 failed to import. Local mode features will be impaired or broken.")


update the warning message :)

laurenyu · 2020-05-22T15:40:40Z

src/sagemaker/amazon/common.py

+        import scipy
+    except ImportError as e:
+        logging.warning("urllib3 failed to import. Local mode features will be impaired or broken.")
+        # Any subsequent attempt to use urllib3 will raise the ImportError


update the comment :)

laurenyu · 2020-05-22T15:41:07Z

tests/unit/test_common.py

@@ -152,195 +150,6 @@ def test_invalid_label():
            write_numpy_to_dense_tensor(f, array, label_data)


-def test_dense_float_write_spmatrix_to_sparse_tensor():


we should still keep the tests

setup.py

sagemaker-bot · 2020-05-22T19:38:35Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-22T19:55:17Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-22T20:05:34Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-22T20:16:58Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-22T20:31:19Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-22T20:33:30Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-22T20:40:35Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-22T20:53:02Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-05-22T21:11:36Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu · 2020-05-26T21:20:28Z

src/sagemaker/amazon/common.py

+    try:
+        import scipy
+    except ImportError as e:
+        logging.warning("scipy is removed from SageMaker Python SDK v2.")


you can still use the warning from the previous error message; just update it to not say "urllib" or "local mode" 😂

e.g. "scipy failed to import. Sparse matrix functions will be impaired or broken."

sagemaker-bot · 2020-06-01T18:14:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 87512d9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-01T18:23:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 87512d9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-01T18:36:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 87512d9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-01T18:44:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5d0acaa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable

looks good to me

sagemaker-bot · 2020-06-01T18:51:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5d0acaa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-01T18:59:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 5d0acaa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-06-01T19:06:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5d0acaa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

fix: remove scipy from dependency

8b59aea

laurenyu reviewed May 22, 2020

View reviewed changes

recover test_common tests

08828ed

black-format

262d293

laurenyu reviewed May 26, 2020

View reviewed changes

update scipy warning message

87512d9

Merge branch 'zwei' into remove-scipy

5d0acaa

laurenyu approved these changes Jun 1, 2020

View reviewed changes

metrizable approved these changes Jun 1, 2020

View reviewed changes

laurenyu merged commit 6eeca73 into aws:zwei Jun 1, 2020

laurenyu mentioned this pull request Jun 9, 2020

Remove scipy from required dependencies #1471

Closed

liujiaorr mentioned this pull request Apr 21, 2024

Unable to use this library in AWS Lambda due to package size exceeded max limit #1200

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove scipy from dependency #1518

fix: remove scipy from dependency #1518

chuyang-deng commented May 20, 2020

sagemaker-bot commented May 20, 2020

sagemaker-bot commented May 20, 2020

sagemaker-bot commented May 21, 2020

sagemaker-bot commented May 21, 2020

laurenyu May 22, 2020

laurenyu May 22, 2020

laurenyu May 22, 2020

sagemaker-bot commented May 22, 2020

sagemaker-bot commented May 22, 2020

sagemaker-bot commented May 22, 2020

sagemaker-bot commented May 22, 2020

sagemaker-bot commented May 22, 2020

sagemaker-bot commented May 22, 2020

sagemaker-bot commented May 22, 2020

sagemaker-bot commented May 22, 2020

sagemaker-bot commented May 22, 2020

laurenyu May 26, 2020

sagemaker-bot commented Jun 1, 2020

sagemaker-bot commented Jun 1, 2020

sagemaker-bot commented Jun 1, 2020

sagemaker-bot commented Jun 1, 2020

metrizable left a comment

sagemaker-bot commented Jun 1, 2020

sagemaker-bot commented Jun 1, 2020

sagemaker-bot commented Jun 1, 2020

		@@ -152,195 +150,6 @@ def test_invalid_label():
		write_numpy_to_dense_tensor(f, array, label_data)


		def test_dense_float_write_spmatrix_to_sparse_tensor():

fix: remove scipy from dependency #1518

fix: remove scipy from dependency #1518

Conversation

chuyang-deng commented May 20, 2020

Merge Checklist

General

Tests

sagemaker-bot commented May 20, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 20, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 21, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 21, 2020

AWS CodeBuild CI Report

laurenyu May 22, 2020

Choose a reason for hiding this comment

laurenyu May 22, 2020

Choose a reason for hiding this comment

laurenyu May 22, 2020

Choose a reason for hiding this comment

sagemaker-bot commented May 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented May 22, 2020

AWS CodeBuild CI Report

laurenyu May 26, 2020

Choose a reason for hiding this comment

sagemaker-bot commented Jun 1, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 1, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 1, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 1, 2020

AWS CodeBuild CI Report

metrizable left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jun 1, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 1, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jun 1, 2020

AWS CodeBuild CI Report