Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isNoWorkToDoValidationError to widen scope of error messages included #536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

warren-burke84
Copy link

Description

There is a function that determines if an error occurred when processing a Cloudformation stack Create Or Update, it appears the at least one of the error messages returned by the AWS API have changed slightly and this update is to make a slight change to the known error messages validation to ensure that the updated error from AWS can be handled by this function.

The error message causing the issue is "CloudFormation failed to preprocess the stack: No updates are to be performed." the current code looks for errors starting with "No updates are to be performed." but it appears AWS has modified the error message to include the additional wording "CloudFormation failed to preprocess the stack: ".

Motivation

This issue currently breaks Azure DevOps pipelines that use the aws-toolkit to perform Cloudformation stack updates where no changes are to be applied, this sometimes happens when a pipeline is re-run using the same Cloudformation template. It has been fixed a couple of times in the past and this is a new iteration on that.

Related Issue(s), If Filed

No related issues.

Testing

Changes tested locally to verify the update works as expected.

Checklist

  • [x ] I have read the README document
  • [ x] I have read the CONTRIBUTING document
  • [ x] My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the changelog using the script npm run newChange

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@warren-burke84 warren-burke84 requested a review from a team as a code owner December 13, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant