fix(MultipartUpload): changed ObjectURL for CompleteMultipartUpload into effectiveUri #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idsulik
force-pushed
the
fix-objecturl
branch
from
75f344d
to
b39de83
Compare
|
Another way to fix it is to replace "%2F" with "/" for the location's URI, which one is preferable? |
|
@stobrien89 Hi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: I spent several hours to figure out why some files return ObjectURL with "%2F", but some files with "/", it turned out that CompleteMultipartUpload puts "Location" URL to ObjectURL while PutObject and CopyObject put the effectiveUri, changed this so CompleteMultipartUpload will return effecitveUri if it's available and "Location" if it's not available.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.