Add options to createPresignedRequest method #2849
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue: None
Description of changes:
This tiny change will make it possible to sign pre-signed-requests with optional parameters, this can be used to make use of this part of the code:
aws-sdk-php/src/Signature/SignatureV4.php
Lines 169 to 171 in 7254925
This wil make it possible to sign the S3 links with a timestamp in the past!
This is very handy if you want to make use of short caching.
Without the options, every signed url will have an unique signature, because time() function is used.
Found here:
https://github.com/clauculo/aws-sdk-php/blob/725492580ef8a49108e39803dc266c25faa30d5a/src/Signature/SignatureV4.php#L171
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.