Allow S3EncryptionClient::putObject to accept any type that implement StreamInterface #2671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
putObject
is throwing an exception if user passed a stream implemented toStreamInterface
. I checked the usage of$plaintext
and found that$plaintext
is using only for constructors ofAesGcmEncryptingStream
andAesEncryptingStream
. Those constructors requiringStreamInterface
as first arguments. So we do not have to stick intoStream
inEncryptionTrait
s.Now we are doing like this.
With this PR we can save some cost like this:-
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.