Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create function to prevent function deprecation message in PHP 8.2 #2625

Closed
wants to merge 2 commits into from

Conversation

jrbarros
Copy link

Description of changes:
Implements function to check if function mb_convert_encoding exists to avoid PHP 8.2 deprecation message

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jrbarros
Copy link
Author

@peterader Can you help me talk to another mod to approve or deny this PR

@yenfryherrerafeliz
Copy link
Contributor

Hi @jrbarros, sorry for the delay on answering this. I see that you are proposing utf8_encode as an alternative for mb_convert_encoding, but utf8_encode is actually deprecated in php 8.2, and hence you will keep getting deprecation warnings. Here is the link to php docs. We did a recent change on SsoTokenProvider where we introduced utf8_encode again. However, this probably needs to be reconsidered again.

Thanks!

@yenfryherrerafeliz
Copy link
Contributor

Hi @jrbarros, thanks for this contribution. We will close this one for now since we need to keep mb_convert_encoding over utf8_encode, since utf8_encode is going to be deprecated in PHP 8.2.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants