Update InternalSDKUTils.DetermineFramework to return standard string … #3302
Conversation
| /// An interface for <see cref="RuntimeInformationWrapper"/> which allows for mocking the <see cref="RuntimeInformation"/> class. | ||
| /// A wrapper is necessary because the class is static. | ||
| /// </summary> | ||
| internal interface IRuntimeInformationWrapper |
There was a problem hiding this comment.
Does this interface need to be marked internal? It's already in the Internal namespace, and in my opinion made this PR much more complicated than necessary.
There was a problem hiding this comment.
Norm asked me to make these internal and utilize InternalsVisibleTo😅.
There was a problem hiding this comment.
I'm fine with either approach. My intention was I wanted the new interface to be treated as internal. Probably not a bad thing to get our unit tests project setup to access internals for future testing.
There was a problem hiding this comment.
I agree it's not a bad thing to have it set up so that we can use it in the future.
sdk/src/Core/Amazon.Util/Internal/_netstandard/InternalSDKUtils.netstandard.cs
Outdated
Show resolved
Hide resolved
| /// An interface for <see cref="RuntimeInformationWrapper"/> which allows for mocking the <see cref="RuntimeInformation"/> class. | ||
| /// A wrapper is necessary because the class is static. | ||
| /// </summary> | ||
| internal interface IRuntimeInformationWrapper |
There was a problem hiding this comment.
I'm fine with either approach. My intention was I wanted the new interface to be treated as internal. Probably not a bad thing to get our unit tests project setup to access internals for future testing.
sdk/test/NetStandard/UnitTests/AWSSDK.UnitTests.Custom.NetStandard.csproj
Show resolved
Hide resolved
…and additional metadata if version parsing fails
peterrsongg
force-pushed
the
petesong/language-version-update
branch
from
3a2e7ac
to
21a28bc
Compare
…and additional metadata if version parsing fails
Description
This updates the
DetermineFrameworkmethod, which previously could return junk like "1-10-2023" or whatever was returned fromGetValidSubstringOrUnknown. This is because people can build their own custom version ofSystem.Runtime.InteropServices.RuntimeInformation.dll.In these cases, where the version is not in the standard format i.e.
n.n.n, we now return a consistent string.In order to mock the
DetermineFrameworkmethod, I had to mock the staticRuntimeInformationclass. This class doesn't implement and interface so I had to create an interface and a wrapper to allow me to inject the mocked version ofRuntimeInformation.Motivation and Context
Internal Ticket 7368
Testing
Added Unit Tests
Dry run passes
Screenshots (if appropriate)
Types of changes
Checklist
License