Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update AWSSDK.Extensions.NETCore.Setup to support native AoT.
Motivation and Context
Fix AoT warnings in the AWSSDK.Extensions.NETCore.Setup assembly by adding new overloads that accept a type parameter.
I was testing an internal application using
Amazon.AspNetCore.DataProtection.SSM
with native AoT to see what compatibility warnings there were, and the transient dependency onAWSSDK.Extensions.NETCore.Setup
flagged warnings due to the lack of AoT support.These changes fix the AoT warnings in the assembly, but the approach may not be what the maintainers would prefer, so this is just a draft for now to solicit feedback on the approach.
If the changes are eventually merged and released, I can do a follow-up PR to
Amazon.AspNetCore.DataProtection.SSM
to consume the updated package version and make any code changes needed.Based on the initial commit in this PR, that would changing this line of code:
Testing
New unit tests added. Further tests can be added once/if the changes are otherwise acceptable.
Types of changes
Checklist
License