Add SDKOption for default Credentials Provider Chain #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If provided in SDKOption, initialization will resolve closure and set that value in static variable. If not provided, configure static variable with DefaultAWSCredentialsProviderChain. Most usages of DefaultAWSCredentialsProviderChain throughout clients has been replaced with GetDefaultCredentialsProviderChain.
2 tasks
jmklix
added
the
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: related to 150; this is kind of a workaround whereby developer can set their default chain to include
STSProfileCredentialsProvider. Just opened an issue / feature request 2814.Description of changes: If provided in
SDKOption, initialization will resolve closure and set that value in static variable. If not provided, configure static variable withDefaultAWSCredentialsProviderChain. Most usages ofDefaultAWSCredentialsProviderChainthroughout clients has been replaced withGetDefaultCredentialsProviderChain.I could use some help writing test cases, and I probably missed a couple places where I need to replace
DefaultAWSCredentialsProviderChain.I know this looks tedious to review; but, all of the logic changes are in
src/aws-cpp-sdk-core. Everything outside of that is just changing existing usages ofDefaultAWSCredentialsProviderChain=>GetDefaultCredentialsProviderChainacross the services' clients.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.