Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDKOption for default Credentials Provider Chain #2814

Open
1 of 2 tasks
MitchellKagerKodiak opened this issue Jan 17, 2024 · 1 comment · May be fixed by #2815
Open
1 of 2 tasks

Add SDKOption for default Credentials Provider Chain #2814

MitchellKagerKodiak opened this issue Jan 17, 2024 · 1 comment · May be fixed by #2815
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue

Comments

@MitchellKagerKodiak
Copy link

Describe the feature

Every service client accepts an AwsCredentialsProviderChain that determines how credentials are resolved. It should be possible to configure a default during SDK initialization.

Use Case

STSProfileCredentialsProvider does not exist in default chain [150]. In certain codebases, it would be much more code-efficient to configure the credentials provider chain during initialization as opposed to passing a chain to construction of every client object.

Proposed Solution

  • Add a new CredentialsProviderChainOptions struct to Aws.h's SDKOptions
  • During InitSDK, check for presence of this struct's closure. If it is present, call some SetDefaultCredentialsProviderChain with the result of the closure. If it is not present, call Set...Chain method with DefaultAWSCredentialsProviderChain (current default)
  • Update all occurrences of DefaultAWSCredentialsProviderChain across clients with GetDefaultCredentialsProviderChain (to resolve to configured value or pre-existing DefaultAWSCredentialsProviderChain).

Other Information

posting a PR right now

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@MitchellKagerKodiak MitchellKagerKodiak added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 17, 2024
@MitchellKagerKodiak MitchellKagerKodiak linked a pull request Jan 17, 2024 that will close this issue
11 tasks
@jmklix
Copy link
Member

jmklix commented Jan 24, 2024

Thanks for opening this feature request and creating a PR to add this option. We are reviewing your PR to see if we would like to accept this changes and change how the credentials work.

@jmklix jmklix added p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jan 24, 2024
@jmklix jmklix linked a pull request Jan 24, 2024 that will close this issue
11 tasks
@jmklix jmklix added the needs-review This issue or pull request needs review from a core team member. label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants