Add Source Link support for enhanced debugging experience #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am looking into this PR. Adding SourceLink support increases the NuGet package size since we are embedding the symbols in the existing package. Doing a quick test showed an increase from 180KB to 239KB for the RuntimeSupport library. I am discussing this with the team to see if this is something we want to do, or go down the route of pushing the symbols package to NuGet separately. That would involve us updating our release infra as well as making updates to this PR. |
ashishdhingra
added
p2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #968
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.