New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cloudformation deploy to accept a paramater file #2828
Comments
Looking over the code it seems we'd just need something around here https://github.com/aws/aws-cli/blob/develop/awscli/customizations/cloudformation/deploy.py#L178 that reads in a JSON file, maybe a quick sanity check, then passes it along to |
Marking as a feature request for cloudformation deploy. @sanathkr thoughts? |
waiting for this feature 👍 |
I would also like the feature for |
Passing a parameters file via something like |
+1 for this feature. Thanks! |
Good Morning! We're closing this issue here on GitHub, as part of our migration to UserVoice for feature requests involving the AWS CLI. This will let us get the most important features to you, by making it easier to search for and show support for the features you care the most about, without diluting the conversation with bug reports. As a quick UserVoice primer (if not already familiar): after an idea is posted, people can vote on the ideas, and the product team will be responding directly to the most popular suggestions. We’ve imported existing feature requests from GitHub - Search for this issue there! And don't worry, this issue will still exist on GitHub for posterity's sake. As it’s a text-only import of the original post into UserVoice, we’ll still be keeping in mind the comments and discussion that already exist here on the GitHub issue. GitHub will remain the channel for reporting bugs. Once again, this issue can now be found by searching for the title on: https://aws.uservoice.com/forums/598381-aws-command-line-interface -The AWS SDKs & Tools Team This entry can specifically be found on UserVoice at: https://aws.uservoice.com/forums/598381-aws-command-line-interface/suggestions/33168409-allow-cloudformation-deploy-to-accept-a-paramater |
+1 for this feature. Thanks! |
Based on community feedback, we have decided to return feature requests to GitHub issues. |
In case anyone is looking for a workaround, you can try using jq, like so: |
I'm going to +1 this feature too. |
I'm replacing
|
Given AWS CodePipeline CloudFormation deployment action requires a specific template configuration file format, it would be good if you could also support this format as well. |
+1 for this. I understand wanting to keep "aws cloudformation deploy" simple, but this command already has individual command line flags for capabilities, tags, and parameters (like all other aws cloudformation commands), but you've made them function differently (only accepting list of string=string on the command line, rather than a JSON structure in a file). You should make all "aws cloudformation" commands work consistently (including use of cli-input-json like almost all aws CLI commands). if you wanted a simplification of the tags construct for "aws cloudformation deploy", you should introduce a different command line flag, like --tags-overrides or --parameters-overrides. |
👍 on the feature request, would be great if this was supported. |
This would be a great feature to have! It would greatly simplify Idempotency when creating cf stacks with the cli 👍 |
+1 |
2 similar comments
+1 |
+1 |
@ColdFire87 @dan-lind @mnwk can you please just 👍 the first issue, and stop spamming whoever is subscribed to this issue? Each comment with 👍 is pinging 20 persons.... |
@pierreozoux Sorry about that, I didn't mean to annoy people :) |
What @cervantek said. I just want to add that I would hope that this ticket tracks implementing all of these options for consistency with
Many people like me will have legacy code that was written using |
+1 to --parameters supports JSON file. |
Our team recently began generating cloudformation templates that were large enough to require an upload to an S3 bucket, so we are now making the transition from create-stack and update-stack to deploy...and are running into the same problem of migrating our parameters file to work with this new command. +1 for this feature |
+1 for this feature |
Guys, please do consider implementing this feature. Using tricks with |
I came across this thread while looking for a solution for passing parameters to If you're a heavy user of CodePipeline for deploying CloudFormation, it's already customary to have your CloudFormation files in the CodePipeline format committed within your repositories. This works great for when you're running a full CI/CD run via the pipeline, but it makes for very tedious local development. I have some scripts that can translate the CodePipeline JSON into the JSON that |
Please implement this! |
Please Implement this! Come on AWS, this has been open for almost 3 years. |
Another thing that is extremely annoying and somewhat related to the topic is the inconsistency between formats for supplying CFN parameters via CLI. I am a The problem arose when I decided to implement something similar to Terraform's Per CLI documentation for
Per CLI documentation for
with also an option to supply JSON. I really don't get why they're different, why This honestly a really strange design - no consistency, and un-justifiable motivation to avoid usage of parameter files. Small (and it is arguable that they're small) things like this really affect productivity. P.S. Didn't notice @pablods90 take on this, but only proves the point that people are keeping re-inventing a wheel due to the lack of basic functionality :( |
+1 |
The adventures of Captain Consistency continue. While we can get away with the usage of [
{
"ParameterKey": "ParamEnv",
"ParameterValue": "prod"
}
] The {
"Parameters": {
"ParamEnv": "prod"
}
} No further comments... Really tired of hitting the same problem over and over and over again. This is bad. |
we ended up just having one-line shell scripts to call |
i think this is one of those issues they are not going to fix, maybe coz their focus now is the cdk? anyways i gave up waiting and trying to shoehorn deploy into doing what i thought it should do and ended up doing what i think most others have done - write my own "upsert" bash script using create and update stack cli commands. 100 lines long but at least it does the job now! |
Hi, I really need this. I truly disappointed to see this situation, where people asking to make this for years but CloudFormation haven't provided yet. What kind of idea drive the team this is acceptable..... |
Hey, we're really sorry that it took such a long time to get to this issue. Could you please have a look at the description of the PR and let us know what do you think about such solution. |
Also, it seems like there is no easy way (at least on Windows Command Prompt CLI) to provide a multi-line parameter. I'd hope with the implementation of this parameter file feature, it would save the multi-line parameter issue. Thank you very much for the great work guys! |
Hi, this PR was merged and released in AWS CLI v.2.0.39. |
@vz10 Thanks for the update. Btw, do you happen to know if this implementation (via a parameter file) allows multi-line parameters? This was one of the things I couldn't get through in the Windows batch environment running AWS CLI. Thanks for your assistance in advance! |
@bs-thomas I didn't test it with multi-line parameters. But I believe if JSON format supports it, it will work fine. It'd be great if you can try it out and give us a feedback. Thank you. |
@vz10 Multi-line indeed is working. However, it looks very ugly with \n Actually, it'd be cool if CLI can suport YAML format for the CLI parameter-overrides ;-) |
@bs-thomas it looks like another feature request. Just create it and it'll it be half the battle of making parameter-overrides understand YAML ;) |
@vz10 Sure, I'll do that right away. Btw, I noticed something unpleasant about the JSON validator. It does not accept integer nor boolean values. So if I have them, it must be specified as a string, else I'll get this response: |
Tada! |
@bs-thomas yeah, it's a bit weird but it's the same behavior that |
When running the
cloudformation deploy
command it would be useful to be able to pass the parameters in as a file (to the--parameter-override
parameter), as can be done with create-stack and update-stack.Also requested here: aws/serverless-application-model#111
The text was updated successfully, but these errors were encountered: