Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cloudformation deploy to accept a paramater file in YAML format #5473

Closed
bs-thomas opened this issue Aug 13, 2020 · 3 comments
Closed
Labels
closed-for-staleness cloudformation package-deploy customization Issues related to CLI customizations (located in /awscli/customizations) feature-request A feature should be added or improved. p3 This is a minor priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@bs-thomas
Copy link

Is your feature request related to a problem? Please describe.
Yes, in aws cloudformation deploy, we now support JSON file as the format for --parameter-overrides. This is really good news, because the long unresolved problem (with Windows especially) with specifying multi-line parameters is now finally resolved by supporting a JSON formatted file.

via this issue: Allow cloudformation deploy to accept a paramater file #2828 (#2828)

However, the values look really ugly. Like this: "first line\nsecond line\nthird line" Ew, yuck!

Describe the solution you'd like
Maybe supporting YAML formatted file will resolve this.

Describe alternatives you've considered
Could be other well-known common formats too, but YAML seems to be the most popular.

Additional context

Something like this?

Parameters:
  DesiredCount: 2
  MaxCapacity: 3
  MinCapacity: 2
  MaximumPercent: 150
  MinimumHealthyPercent: 49
  MultiLineStuff: |
    first line
    second line
    third line

Thank you very much for the time going through this.

@bs-thomas bs-thomas added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 13, 2020
@kdaily
Copy link
Member

kdaily commented Aug 14, 2020

Hi @bs-thomas, I see the related thread where you discussed this. Marking as a feature request. Thanks!

@kdaily kdaily added cloudformation package-deploy and removed needs-triage This issue or PR still needs to be triaged. labels Aug 14, 2020
@kdaily kdaily added the customization Issues related to CLI customizations (located in /awscli/customizations) label Nov 12, 2020
@tim-finnigan tim-finnigan added the p3 This is a minor priority issue label Nov 1, 2022
@tim-finnigan
Copy link
Contributor

I think this overlaps with #2275, can anyone confirm or call out any major distinctions between the issues? To consolidate tracking we might want to close this as a duplicate in favor of that older issue.

@tim-finnigan tim-finnigan added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Feb 28, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

Greetings! It looks like this issue hasn’t been active in longer than five days. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Mar 5, 2023
@github-actions github-actions bot closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness cloudformation package-deploy customization Issues related to CLI customizations (located in /awscli/customizations) feature-request A feature should be added or improved. p3 This is a minor priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants