Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudformation external parameter file do not support YAML file #2275

Open
Yaowenjie opened this issue Nov 3, 2016 · 170 comments
Open

Cloudformation external parameter file do not support YAML file #2275

Yaowenjie opened this issue Nov 3, 2016 · 170 comments
Labels
cloudformation package-deploy community contribution-ready customization Issues related to CLI customizations (located in /awscli/customizations) feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue

Comments

@Yaowenjie
Copy link

I used aws-cli to update my stacks, and want to use an external yaml file (dev.yaml) as parameters file like below:

aws cloudformation update-stack --stack-name test --template-body file://./api-test.yaml --parameters file://./dev.yaml

In dev.yaml, it only has:

---
- ParameterKey: APICacheClusterSize
  ParameterValue: '1.6'

However, I got this Error message when I run the update command above:

Error parsing parameter '--parameters': Expected: '=', received: '-' for input:

---
- ParameterKey: APICacheClusterSize
^
  ParameterValue: '1.6'

If I use JSON file with same context as below, and use it instead of dev.yaml, it works fine:

[
  {
    "ParameterKey": "APICacheClusterSize",
    "ParameterValue": "1.6"
  }
]

So, can the external parameters file for aws cloudformation be YAML file? or will...?

@stealthycoin stealthycoin added the feature-request A feature should be added or improved. label Nov 17, 2016
@stealthycoin
Copy link
Contributor

Hi, we currently don't have any plans to support YAML as part of the command line arguments. I will mark this as a feature request as I can see how it might be useful for some people.

The contents of the the file you provide to --parameters is loaded and dumped straight in as an argument so you can only have the file contents be in one of two formats:
Shorthand syntax:
ParameterKey=string,ParameterValue=string,UsePreviousValue=boolean
or JSON syntax:

[
    {
         "ParameterKey": "string",
         "ParameterValue": "string",
         "UsePreviousValue": true|false
     }
]

@lorengordon
Copy link
Contributor

I'll second this feature request.

@jlm742
Copy link

jlm742 commented Feb 1, 2017

I'll second it too

@csgyuricza
Copy link

+1

@dcw329
Copy link

dcw329 commented Feb 6, 2017

Please. This is critical for us.

@thijsdev
Copy link

thijsdev commented Feb 9, 2017

+1

@ddepaoli3
Copy link

absolutely +1

@codeasone
Copy link

+1 allowing YAML formatted data for --template-body but not for --parameters is awkward

@youngpm
Copy link

youngpm commented Feb 23, 2017

👍

3 similar comments
@amitlalani
Copy link

+1

@andymotta
Copy link

+1

@jdbass
Copy link

jdbass commented Apr 11, 2017

+1

@mazerty
Copy link

mazerty commented Apr 22, 2017

since you can provide a template in yaml, you should be able to provide the parameters in yaml too
i think this feature is a must-have

@KWSeamanCerner
Copy link

+1

@nungster
Copy link

+100

@bombadiltom
Copy link

+1

@sidja
Copy link

sidja commented May 23, 2017

+100

@nthansen
Copy link

+1

@mbailey
Copy link
Contributor

mbailey commented May 30, 2017

" https://gist.github.com/mbailey/2f7c878eed123cab6fb125117f35aecc
"
" yamlise - see YAML when editing JSON files in vim.
"
" Created for people with JSON phobia, this should
" only be used when all attempts to master JSON
" have failed. http://www.json.org/
"
" I hope it isn't too late for these folks!
" 'Please. This is critical for us.'
" #2275 (comment)
"
" Installation
" ============
" 1. Install cfn-flip https://github.com/awslabs/aws-cfn-template-flip
" 2. Include this file in your ~/.vimrc
" 3. vim cloudformation-params.json
" YOU SHOULD NOW SEE THE YAML YOU CRAVE
" 4. :wq
" The file should now contain the JSON Amazon CLI expects
"
:augroup yamlise
: autocmd!
: autocmd BufReadPost,FileReadPost *.json '[,']!cfn-flip
: autocmd BufWritePre,FileWritePre *.json '[,']!cfn-flip
: autocmd FileAppendPre *.json '[,']!cfn-flip
:augroup END

@rudolf-trinimbus
Copy link

+1

9 similar comments
@stefnovabasiq
Copy link

+1

@therin
Copy link

therin commented Jun 28, 2017

+1

@shlompy
Copy link

shlompy commented Jun 29, 2017

+1

@KatherineTomkins
Copy link

+1

@aterentic-basiq
Copy link

+1

@nhmaha
Copy link

nhmaha commented Jul 6, 2017

+1

@giuppo
Copy link

giuppo commented Jul 6, 2017

+1

@g-io
Copy link

g-io commented Jul 6, 2017

+1

@199911
Copy link

199911 commented Jul 11, 2017

+1

@aloneguid
Copy link

still waiting on XML support

@joes-myob
Copy link

joes-myob commented May 3, 2022

+100 - would like yaml too

@justindho justindho added community contribution-ready and removed needs-review This issue or pull request needs review from a core team member. labels May 11, 2022
@motdde
Copy link

motdde commented Jul 6, 2022

Commenting to get notified when this get merged

@spedersen-emailage
Copy link

+1 for YAML support. This issue has been open for 5 years, 8 months, 17 days as of this comment.

Documentation (like this) for toolkits that use the AWS CLI still claim YAML support, too.

@bbetic
Copy link

bbetic commented Jul 28, 2022

+1

@bdsys
Copy link

bdsys commented Oct 17, 2022

+1 for YAML support.

@tim-finnigan tim-finnigan added the p2 This is a standard priority issue label Nov 15, 2022
@thisishantzz
Copy link

+1.

I really hope this gets taken up.

@omerfsen
Copy link

omerfsen commented Dec 3, 2022

6 years passed and still no action taken

@matthewflannery
Copy link

matthewflannery commented Dec 4, 2022

lol im still following this.. I ended up using https://github.com/mikefarah/yq btw for anyone who hasnt adopted a similar process...

@sydrawat01
Copy link

Is this still being considered? Seems like a lost cause. The only way out seems like mixing markups to use JSON and YAML, or , use the yq package as mentioned by @matthewflannery and @davegallant

@johnjeffers
Copy link

I pinged AWS support about this issue, and just got the standard response about how "we are aware of this, but we provide no ETA on new features". In fairness, what else are they going to say, I guess? Maybe there's some technical reason that this is harder to accomplish than it seems. I can't come up with any other reason why this has been ignored for 6+ years.

@tim-finnigan tim-finnigan added cloudformation package-deploy customization Issues related to CLI customizations (located in /awscli/customizations) needs-review This issue or pull request needs review from a core team member. and removed cloudformation labels Feb 28, 2023
@tim-finnigan
Copy link
Contributor

Hi all, thanks for your patience. We understand your frustration regarding issues like this that stay open for years. Unfortunately issues involving the CloudFormation customization are not getting prioritized at the moment. The individuals who originally owned this customization have since left the team or have gone on to work on the AWS SAM CLI (which may offer some of the functionality requested in issues in this repository).

I've tried to get more attention on these issues but it is challenging when the ownership is in limbo. I think some more internal coordination is required to form a plan moving forward. In the meantime I encourage anyone interested in seeing a feature implemented to 👍 the issue and comment if you have additional information to share regarding a use case. If anyone wants to try creating a PR to implement feature requests like this, you can refer to the CONTRIBUTING.rst guide.

@johnjeffers
Copy link

@tim-finnigan thank you! Even if it might not be what we’d like to hear, I really appreciate you taking the time to reply and give some info about what’s happening.

@dragonspaw
Copy link

I would very much like the option to write my parameter files in YAML.
One, they are more legible and easier to write.
Two, JSON doesn't support comments; some of my param files are long with multiple contributors.

@maulik-modi22
Copy link

@tim-finnigan , Is there any hope to have YAML support in 2023?

@ghost
Copy link

ghost commented Aug 8, 2023

+1 for YAML support.

@aidando73
Copy link

aidando73 commented Aug 23, 2023

I'm happy to try implementing this.

👀 ...

@aidando73
Copy link

aidando73 commented Aug 25, 2023

@tim-finnigan @aBurmeseDev @RyanFitzSimmonsAK I've submitted a PR for this #8133. Let me know if I've missed anything

Screencast.from.25-08-23.18.45.15.webm

@amberkushwaha
Copy link

Add a comment in the main section for the given time format and main section catalogue in the straining the main input in the issues just get open the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloudformation package-deploy community contribution-ready customization Issues related to CLI customizations (located in /awscli/customizations) feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue
Projects
Status: Contribution Ready
Development

No branches or pull requests