New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iam): add imported user to a group #13698
Conversation
public addToGroup(_group: IGroup): void { | ||
throw new Error('Cannot add imported User to Group'); | ||
public addToGroup(group: IGroup): void { | ||
new CfnUserToGroupAddition(Stack.of(group), `${this.userName}Group${this.groupId}`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woooaahhhh
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@rix0rrr can you reapprove? Looks like
|
@rix0rrr ping |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Allow adding an imported user to a group by implementing `addToGroup()` with [`AWS::IAM::UserToGroupAddition`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-iam-addusertogroup.html). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Allow adding an imported user to a group by implementing `addToGroup()` with [`AWS::IAM::UserToGroupAddition`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-iam-addusertogroup.html). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Allow adding an imported user to a group by implementing
addToGroup()
withAWS::IAM::UserToGroupAddition
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license