feat(aws-ecs-patterns): add circuitbreaker deployment configuration #13504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
daveharmon
changed the title
daveharmon
force-pushed
the
12360
branch
4 times, most recently
from
2ce3f1b
to
50b477c
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
closing in favor of #12719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The circuitbreaker deployment feature was announced here: https://aws.amazon.com/blogs/containers/announcing-amazon-ecs-deployment-circuit-breaker/
It is already supported by the base ECS constructs, this CR just adds the configuration option to the high-level constructs for which it is relevant.
This is my first contribution, probably deserves extra scrutiny. In particular I modified a unit test. It seems that is not considered best practice here, but I felt adding a whole new unit test would be overkill. My changes shouldn't modify the behavior of the unit tests, they should just expand on the case.
Related to: #12360
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license