Set deploymentController to ECS deployment type if circuitBreaker is …

…defined
aws · Mar 7, 2021 · 73c2779 · 73c2779
1 parent 06b5d3b
commit 73c2779
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 27 deletions.
diff --git a/packages/@aws-cdk/aws-ecs-patterns/README.md b/packages/@aws-cdk/aws-ecs-patterns/README.md
@@ -410,9 +410,6 @@ const service = new ApplicationLoadBalancedFargateService(stack, 'Service', {
   taskImageOptions: {
     image: ecs.ContainerImage.fromRegistry("amazon/amazon-ecs-sample"),
   },
-  deploymentController: {
-    type: ecs.DeploymentControllerType.ECS,
-  },
   circuitBreaker: { rollback: true },
 });
 ```

diff --git a/packages/@aws-cdk/aws-ecs-patterns/test/ec2/test.l3s.ts b/packages/@aws-cdk/aws-ecs-patterns/test/ec2/test.l3s.ts
@@ -1112,9 +1112,6 @@ export = {
       taskImageOptions: {
         image: ecs.ContainerImage.fromRegistry('amazon/amazon-ecs-sample'),
       },
-      deploymentController: {
-        type: ecs.DeploymentControllerType.ECS,
-      },
       circuitBreaker: { rollback: true },
     });
 
@@ -1126,6 +1123,9 @@ export = {
           Rollback: true,
         },
       },
+      DeploymentController: {
+        Type: 'ECS',
+      },
     }));
 
     test.done();
@@ -1145,9 +1145,6 @@ export = {
       taskImageOptions: {
         image: ecs.ContainerImage.fromRegistry('amazon/amazon-ecs-sample'),
       },
-      deploymentController: {
-        type: ecs.DeploymentControllerType.ECS,
-      },
       circuitBreaker: { rollback: true },
     });
 
@@ -1159,6 +1156,9 @@ export = {
           Rollback: true,
         },
       },
+      DeploymentController: {
+        Type: 'ECS',
+      },
     }));
 
     test.done();

diff --git a/packages/@aws-cdk/aws-ecs-patterns/test/ec2/test.queue-processing-ecs-service.ts b/packages/@aws-cdk/aws-ecs-patterns/test/ec2/test.queue-processing-ecs-service.ts
@@ -209,9 +209,6 @@ export = {
       maxHealthyPercent: 150,
       serviceName: 'ecs-test-service',
       family: 'ecs-task-family',
-      deploymentController: {
-        type: ecs.DeploymentControllerType.CODE_DEPLOY,
-      },
       circuitBreaker: { rollback: true },
     });
 
@@ -229,7 +226,7 @@ export = {
       LaunchType: 'EC2',
       ServiceName: 'ecs-test-service',
       DeploymentController: {
-        Type: 'CODE_DEPLOY',
+        Type: 'ECS',
       },
     }));
 

diff --git a/packages/@aws-cdk/aws-ecs-patterns/test/fargate/test.load-balanced-fargate-service.ts b/packages/@aws-cdk/aws-ecs-patterns/test/fargate/test.load-balanced-fargate-service.ts
@@ -436,9 +436,6 @@ export = {
       taskImageOptions: {
         image: ecs.ContainerImage.fromRegistry('/aws/aws-example-app'),
       },
-      deploymentController: {
-        type: ecs.DeploymentControllerType.ECS,
-      },
       circuitBreaker: { rollback: true },
     });
     // THEN
@@ -449,6 +446,9 @@ export = {
           Rollback: true,
         },
       },
+      DeploymentController: {
+        Type: 'ECS',
+      },
     }));
     test.done();
   },
@@ -462,9 +462,6 @@ export = {
       taskImageOptions: {
         image: ecs.ContainerImage.fromRegistry('/aws/aws-example-app'),
       },
-      deploymentController: {
-        type: ecs.DeploymentControllerType.ECS,
-      },
       circuitBreaker: { rollback: true },
     });
     // THEN
@@ -475,6 +472,9 @@ export = {
           Rollback: true,
         },
       },
+      DeploymentController: {
+        Type: 'ECS',
+      },
     }));
     test.done();
   },

diff --git a/packages/@aws-cdk/aws-ecs-patterns/test/fargate/test.queue-processing-fargate-service.ts b/packages/@aws-cdk/aws-ecs-patterns/test/fargate/test.queue-processing-fargate-service.ts
@@ -344,9 +344,6 @@ export = {
       serviceName: 'fargate-test-service',
       family: 'fargate-task-family',
       platformVersion: ecs.FargatePlatformVersion.VERSION1_4,
-      deploymentController: {
-        type: ecs.DeploymentControllerType.CODE_DEPLOY,
-      },
       circuitBreaker: { rollback: true },
     });
 
@@ -365,7 +362,7 @@ export = {
       ServiceName: 'fargate-test-service',
       PlatformVersion: ecs.FargatePlatformVersion.VERSION1_4,
       DeploymentController: {
-        Type: 'CODE_DEPLOY',
+        Type: 'ECS',
       },
     }));
 

diff --git a/packages/@aws-cdk/aws-ecs/lib/base/base-service.ts b/packages/@aws-cdk/aws-ecs/lib/base/base-service.ts
@@ -387,7 +387,9 @@ export abstract class BaseService extends Resource
       },
       propagateTags: props.propagateTags === PropagatedTagSource.NONE ? undefined : props.propagateTags,
       enableEcsManagedTags: props.enableECSManagedTags ?? false,
-      deploymentController: props.deploymentController,
+      deploymentController: props.circuitBreaker ? {
+        type: DeploymentControllerType.ECS,
+      } : props.deploymentController,
       launchType: launchType,
       capacityProviderStrategy: props.capacityProviderStrategies,
       healthCheckGracePeriodSeconds: this.evaluateHealthGracePeriod(props.healthCheckGracePeriod),
@@ -937,4 +939,4 @@ function determineContainerNameAndPort(options: DetermineContainerNameAndPortOpt
   }
 
   return {};
-}
+}
diff --git a/packages/@aws-cdk/aws-ecs/test/fargate/fargate-service.test.ts b/packages/@aws-cdk/aws-ecs/test/fargate/fargate-service.test.ts
@@ -294,7 +294,7 @@ nodeunitShim({
         maxHealthyPercent: 150,
         minHealthyPercent: 55,
         deploymentController: {
-          type: ecs.DeploymentControllerType.CODE_DEPLOY,
+          type: ecs.DeploymentControllerType.ECS,
         },
         circuitBreaker: { rollback: true },
         securityGroup: new ec2.SecurityGroup(stack, 'SecurityGroup1', {
@@ -326,7 +326,7 @@ nodeunitShim({
           },
         },
         DeploymentController: {
-          Type: ecs.DeploymentControllerType.CODE_DEPLOY,
+          Type: ecs.DeploymentControllerType.ECS,
         },
         DesiredCount: 2,
         HealthCheckGracePeriodSeconds: 60,
@@ -1978,6 +1978,9 @@ nodeunitShim({
             Rollback: true,
           },
         },
+        DeploymentController: {
+          Type: ecs.DeploymentControllerType.ECS,
+        },
       }));
 
       test.done();