enable cgo for nvidia code #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you check |
petderek
approved these changes
Nov 15, 2018
| @@ -37,14 +37,14 @@ mkdir -p "${SRCPATH}" | |||
| ln -s "${TOPWD}/ecs-init" "${SRCPATH}" | |||
| cd "${SRCPATH}/ecs-init" | |||
| if [[ "$1" == "dev" ]]; then | |||
| go build -tags 'development' -ldflags "${VERSION_FLAG} ${GIT_HASH_FLAG} ${GIT_DIRTY_FLAG}" \ | |||
| CGO_ENABLED=1 CGO_LDFLAGS_ALLOW='-Wl,--unresolved-symbols=ignore-in-object-files' go build -tags 'development' -ldflags "${VERSION_FLAG} ${GIT_HASH_FLAG} ${GIT_DIRTY_FLAG}" \ | |||
There was a problem hiding this comment.
nit: maybe put the flags into another variable since we repeat later
jahkeup
reviewed
Nov 21, 2018
| @@ -37,14 +37,14 @@ mkdir -p "${SRCPATH}" | |||
| ln -s "${TOPWD}/ecs-init" "${SRCPATH}" | |||
| cd "${SRCPATH}/ecs-init" | |||
| if [[ "$1" == "dev" ]]; then | |||
| go build -tags 'development' -ldflags "${VERSION_FLAG} ${GIT_HASH_FLAG} ${GIT_DIRTY_FLAG}" \ | |||
| CGO_ENABLED=1 CGO_LDFLAGS_ALLOW='-Wl,--unresolved-symbols=ignore-in-object-files' go build -tags 'development' -ldflags "${VERSION_FLAG} ${GIT_HASH_FLAG} ${GIT_DIRTY_FLAG}" \ | |||
There was a problem hiding this comment.
I couldn't find anything to clarify the --unresolved-symbols=ignore-in-object-files portion of the flag, can you give some background on why these linker options are required for building with CGO specifically for enabling nvidia code?
There was a problem hiding this comment.
vendor package for nvml APIs uses the cgo ldflags here -
Looks like only certain ldflags are whitelisted by default (golang/go#23749) and hence the build error as mentioned in the summary of this PR.
jahkeup
approved these changes
Nov 21, 2018
| @@ -37,14 +37,14 @@ mkdir -p "${SRCPATH}" | |||
| ln -s "${TOPWD}/ecs-init" "${SRCPATH}" | |||
| cd "${SRCPATH}/ecs-init" | |||
| if [[ "$1" == "dev" ]]; then | |||
| go build -tags 'development' -ldflags "${VERSION_FLAG} ${GIT_HASH_FLAG} ${GIT_DIRTY_FLAG}" \ | |||
| CGO_ENABLED=1 CGO_LDFLAGS_ALLOW='-Wl,--unresolved-symbols=ignore-in-object-files' go build -tags 'development' -ldflags "${VERSION_FLAG} ${GIT_HASH_FLAG} ${GIT_DIRTY_FLAG}" \ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
address build error
go build github.com/aws/amazon-ecs-init/ecs-init/vendor/github.com/NVIDIA/gpu-monitoring-tools/bindings/go/nvml: invalid flag in #cgo LDFLAGS: -Wl,--unresolved-symbols=ignore-in-object-filesImplementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License: yes