Improve CannotPullContainerError message #4172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineonine
force-pushed
the
CannotPullContainerError-msg-improvement
branch
from
36a335b
to
ba6babc
Compare
|
closing in favor of #4181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change introduces new abstraction to parse known errors and augment error message with extra useful context.
The first error that we handle now is
CannotPullContainerError, spefically, theAPI 404 repository not founderror.The change attempts to update error message when agent is trying to pull image using execution role.
Implementation details
error_messages.goengine.pullAndUpdateContainerReferencewe use new functionality to improve error when image pull failed due to API 404 (repository not found) errorTesting
error_messages_test.godocker_task_engine_test.goto capture state change event with augmented message.New tests cover the changes:
yes
Description for the changelog
Augment CannotPullContainerError message with extra context to aid in troubleshooting tasks
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.