Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for alternative docker runtimes #4073

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Support for alternative docker runtimes #4073

wants to merge 6 commits into from

Conversation

mliezun
Copy link

@mliezun mliezun commented Jan 14, 2024

Summary

Solves aws/containers-roadmap#2345

Implementation details

  • Read variable ECS_DOCKER_RUNTIME.
  • Store in types.Config new attribute: Runtime str
  • When starting a task pass the HostConfig with hostconfig.Runtime = cfg.Runtime as read from env variable.

Testing

  • Added unittests to check that the new variable is correctly read and passed to the docker client.

New tests cover the changes: yes

Description for the changelog

Feature - Support for alternative docker runtimes

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mliezun mliezun requested a review from a team as a code owner January 14, 2024 20:50
@hozkaya2000 hozkaya2000 changed the base branch from master to dev April 9, 2024 23:44
@sparrc
Copy link
Contributor

sparrc commented Apr 22, 2024

Hi Miguel, could you explain how you are using this and how it's been tested? Are you currently using some alternative docker runtime successfully with ECS?

@mliezun
Copy link
Author

mliezun commented Apr 23, 2024

Hi @sparrc, as explained in the linked issue, I was trying to use sysbox with ECS containers and found this guide: https://aws.amazon.com/pt/blogs/aws-brasil/utilizando-runtimes-customizados-no-amazon-ecs

It needed some tweaks to make it work with the latest version of Amazon Linux 2 but I got it working.

By modifying the agent itself to support alternative runtimes we make the process for configuring the AMI a lot easier. Instead of having to run the agent by itself, configuring docker and configuring the network we just need to set ECS_DOCKER_RUNTIME=sysbox-runc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants