Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Custom Network and Network Alias settings #3793

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

jsuchenia
Copy link

Summary

Add support for Custom Network and Network Alias settings. It's useful when running more that two containers that should communicate via local network.

Implementation details

This patch provide two new configuration variables:

  • ECS_OVERRIDE_BRIDGE_NETWORK_NAME - when set, all containers created with NetworkType bridge will be set to this network name. This is equivalent of --net <name> parameter of docker run command
  • ECS_ADD_CONTAINER_NAME_AS_NETWORK_ALIAS - when set to true, and when container is using custom network - then container name will be assigned as a network alias. This is equivalent of --network-alias <container-name> parameter of docker run command.

Testing

New tests cover the changes: no

Description for the changelog

Enhancement - Create containers in a custom network and register their name as network alias

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jsuchenia jsuchenia requested a review from a team as a code owner July 10, 2023 14:04
@jsuchenia jsuchenia changed the base branch from master to dev July 10, 2023 14:04
@jsuchenia
Copy link
Author

@fierlion I've fixed tests - now they should pass, however do not cover a new functionality

README.md Outdated Show resolved Hide resolved
Co-authored-by: Woz <stuart-warren@users.noreply.github.com>
@ofiliz
Copy link
Contributor

ofiliz commented Jul 13, 2023

Thanks for the PR, however this is not a bug fix but an entirely new feature request. It has to go through proper channels before any CRs. Please hold.

@jsuchenia
Copy link
Author

jsuchenia commented Jul 13, 2023

Thanks for the PR, however this is not a bug fix but an entirely new feature request. It has to go through proper channels before any CRs. Please hold.

I've never marked it as a bugfix - we maintain this patch for our purposes, and I asked our Account Manager if we can propose it as a change. AFAIK your team should get a separate email/message about it.

We use this functionality. with ECS Anywhere aka External service.

@daveseff
Copy link

It's been almost a year. Are we ever going to see this added? My company also has to build from this PR and we have talked to our account manager as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants