Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Images root to custom domain #583

Merged
merged 4 commits into from May 15, 2024
Merged

Align Images root to custom domain #583

merged 4 commits into from May 15, 2024

Conversation

BastLeblanc
Copy link
Contributor

Issue #, if available: If CloudfrontCustomDomain is specified, use it also in images root to face all traffic through the custom domain

Description of changes:

Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@BastLeblanc BastLeblanc marked this pull request as ready for review May 14, 2024 18:01
@BastLeblanc BastLeblanc requested a review from gfaires May 14, 2024 18:01
Copy link
Contributor

@gfaires gfaires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and deploys ok

@gfaires gfaires merged commit 6e07ee1 into master May 15, 2024
2 checks passed
@gfaires gfaires deleted the image-root branch May 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

None yet

2 participants