docs: Update in Custom Networking for vpc-cni instructions #1935
+78
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s well as a warning in case a private cluster is being used
… and format updates
herrerasm
changed the title
bryantbiggs
reviewed
May 15, 2024
bryantbiggs
reviewed
May 15, 2024
bryantbiggs
reviewed
May 15, 2024
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR includes additional information on the provider for the custom resource for kubectl_manifest, the IRSA role needed and additional clarifications for private clusters.
Motivation and Context
After working with the blueprints, I was not able to make work the custom networking only using the documentation and had to do further research that took longer than expected.
How was this change tested?
pre-commit run -awith this PRAdditional Notes