Fix: PyTest failing tests due to name conflict #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon running the suite of pytests tests I encountered some of the tests failing. This was due to the `setup` function in `crhelper_log_helper.py` conflicting with the `pytest` setup module. To fix this I have renamed the `setup` function to `setupLogger` and updated all the references to this. I've also updated the classifiers in `setu.py` to include the latest Python releases
thoithoi58
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon running the suite of pytests tests I encountered some of the tests failing. This was due to the
setupfunction incrhelper_log_helper.pyconflicting with thepytestsetup module. To fix this I have renamed thesetupfunction tosetupLoggerand updated all the references to this. I've also updated the classifiers insetup.pyto include the latest Python releasesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.