Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the example for resources that do not support the Tags property #285

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix the example for resources that do not support the Tags property #285

wants to merge 5 commits into from

Commits on Oct 3, 2022

  1. Add some more resources without Tags property 

    * AWS::KMS::Alias
* AWS::SageMaker::NotebookInstanceLifecycleConfig
* AWS::Lambda::Permission
* AWS::Athena::NamedQuery
* AWS::Athena::PreparedStatement
* AWS::S3::BucketPolicy
    @scottschreckengaust
    scottschreckengaust committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6d10a8b View commit details
    Browse the repository at this point in the history

  2. Remove "common" tag guard 

    Not all resources have a Tags property, this guard belongs in a
separate rule unrelated to encryption for Dynamo.
    @scottschreckengaust
    scottschreckengaust committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    99d0c84 View commit details
    Browse the repository at this point in the history

  3. Add resources without Tags property. 

    From https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cfn-resource-specification.html
    @scottschreckengaust
    scottschreckengaust committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6c6a1a5 View commit details
    Browse the repository at this point in the history

  4. Added two resources without Tags outside us-east-1 

    There are four regions without Tags property for IoT::TopicRule
There are four regions without Tags property for Logs::LogGroup
    @scottschreckengaust
    scottschreckengaust committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    f899034 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Merge branch 'aws-cloudformation:main' into resources-without-tags-pr… 

    …operty
    @scottschreckengaust
    scottschreckengaust committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    dbcfb6e View commit details
    Browse the repository at this point in the history