[Misc] Removing unnecessary public modifiers (#470)

* changing visibility modifiers for common structured reporter * changing visibility modifiers for structured reporter trait, and junit reporter
aws-cloudformation · Feb 20, 2024 · 43486ec · 43486ec
1 parent 61215ac
commit 43486ec
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/guard/src/commands/reporters/mod.rs b/guard/src/commands/reporters/mod.rs
@@ -85,11 +85,11 @@ impl<'report> JunitReport<'report> {
     }
 }
 
-pub struct JunitReporter<'reporter> {
-    pub(crate) rules: Vec<(RulesFile<'reporter>, &'reporter str)>,
-    pub(crate) data: Vec<DataFile>,
-    pub writer: &'reporter mut crate::utils::writer::Writer,
-    pub exit_code: i32,
+struct JunitReporter<'reporter> {
+    rules: Vec<(RulesFile<'reporter>, &'reporter str)>,
+    data: Vec<DataFile>,
+    writer: &'reporter mut crate::utils::writer::Writer,
+    exit_code: i32,
 }
 
 impl<'reporter> JunitReporter<'reporter> {

diff --git a/guard/src/commands/reporters/validate/structured.rs b/guard/src/commands/reporters/validate/structured.rs
@@ -12,7 +12,7 @@ use crate::rules::Status;
 use crate::utils::writer::Writer;
 use colored::Colorize;
 
-pub trait StructuredReporter {
+pub(crate) trait StructuredReporter {
     fn report(&mut self) -> rules::Result<i32>;
 }
 
@@ -85,12 +85,12 @@ impl<'eval> StructuredEvaluator<'eval> {
     }
 }
 
-pub struct CommonStructuredReporter<'reporter> {
-    pub(crate) rules: Vec<(RulesFile<'reporter>, &'reporter str)>,
-    pub(crate) data: Vec<DataFile>,
-    pub writer: &'reporter mut crate::utils::writer::Writer,
-    pub exit_code: i32,
-    pub output: OutputFormatType,
+struct CommonStructuredReporter<'reporter> {
+    rules: Vec<(RulesFile<'reporter>, &'reporter str)>,
+    data: Vec<DataFile>,
+    writer: &'reporter mut crate::utils::writer::Writer,
+    exit_code: i32,
+    output: OutputFormatType,
 }
 
 impl<'reporter> StructuredReporter for CommonStructuredReporter<'reporter> {