Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cleanup of rules to v1 standard #3237

Merged
merged 2 commits into from May 13, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • More cleanup of rules to v1 standard

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.44%. Comparing base (d394c83) to head (cf2bc19).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
- Coverage   92.53%   92.44%   -0.10%     
==========================================
  Files         308      308              
  Lines       10667    10644      -23     
  Branches     2270     2263       -7     
==========================================
- Hits         9871     9840      -31     
- Misses        458      465       +7     
- Partials      338      339       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 8fc58b9 into aws-cloudformation:main May 13, 2024
21 of 22 checks passed
@kddejong kddejong deleted the v1-cleanup/2024/05/12 branch May 13, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant