[DBSnapshot] create new resource DBSnapshot #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khebul
reviewed
Jul 1, 2022
| "description": "An example resource schema demonstrating some basic constructs and validation rules.", | ||
| "sourceUrl": "https://github.com/aws-cloudformation/aws-cloudformation-rpdk.git", | ||
| "definitions": { | ||
| "Tag": { |
There was a problem hiding this comment.
I believe we need to mark resource as taggable according to the resource schema: https://github.com/aws-cloudformation/cloudformation-resource-schema/blob/master/src/main/resources/schema/provider.definition.schema.v1.json#L121
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "DBSnapshotIdentifier": "dbsnapshot-contract-test", | |||
| "DBInstanceIdentifier": "postgresql-3" | |||
There was a problem hiding this comment.
I believe contract tests will require this instance to exist. Can we include template for that instance in this PR?
| .translateToServiceRequest(Function.identity()) | ||
| // this skips the call and goes directly to stabilization | ||
| .makeServiceCall(EMPTY_CALL) | ||
| .stabilize((resourceModel, response, proxyInvocation, model, callbackContext) -> isStabilized(resourceModel, proxyInvocation)).progress(); |
There was a problem hiding this comment.
Is handleErrors call omitted intentionally here?
| "read": { | ||
| "permissions": [ | ||
| "rds:DescribeDBSnapshots", | ||
| "rds:ListTagsForResource" |
There was a problem hiding this comment.
I don't think I see any invocations of ListTagsForResource. Am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This changes contains DBSnapshot resource implementation following most recent AWS RDS Documentation: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_CreateSnapshot.html
Which includes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.