Support for suspicious activity screen #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last one, i swear haha.
Well, trying to get the github action working i got into a new issue: it runs from a very different IP than my home network. Of course Microsoft is whinny about it and forces you to enter MFA again (not sure why tho?).
Well, this PR adds supports to that "suspicious activity screen", clicking the button that redirects you to OTP auth (maybe it would be worth it to try and add support for SMS too? But i'm not sure what the classes are).
I haven't been able to find any (any at all) element exclusive to that screen, so i used a text to match the title ("Suspicious activity detected"). This is not the same as a normal selector, so i added an attribute (
selectorX) for running XPath queries.