New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(swift): Fixing Auth category for Gen2 #7576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisebas
reviewed
May 13, 2024
...pages/[platform]/build-a-backend/auth/connect-your-frontend/manage-user-attributes/index.mdx
Outdated
Show resolved
Hide resolved
...ages/[platform]/build-a-backend/auth/connect-your-frontend/using-the-authenticator/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/auth/concepts/tokens-and-credentials/index.mdx
Outdated
Show resolved
Hide resolved
…credentials/index.mdx Co-authored-by: Sebastian Villena <97059974+ruisebas@users.noreply.github.com>
…d/using-the-authenticator/index.mdx Co-authored-by: Sebastian Villena <97059974+ruisebas@users.noreply.github.com>
ruisebas
previously approved these changes
May 13, 2024
josefaidt
reviewed
May 13, 2024
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/switch-auth/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
May 13, 2024
josefaidt
reviewed
May 13, 2024
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/sign-in/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
May 13, 2024
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/switch-auth/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
May 13, 2024
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/switch-auth/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
May 13, 2024
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/switch-auth/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
May 13, 2024
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/switch-auth/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
May 13, 2024
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/switch-auth/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
May 13, 2024
josefaidt
reviewed
May 13, 2024
…d/sign-in/index.mdx Co-authored-by: josef <josef.aidt@gmail.com>
…d/switch-auth/index.mdx Co-authored-by: josef <josef.aidt@gmail.com>
…gen2-auth-doc-fix
ruisebas
approved these changes
May 14, 2024
josefaidt
approved these changes
May 15, 2024
timngyn
approved these changes
May 15, 2024
timngyn
reviewed
May 15, 2024
When you import and use the `signInWithRedirect` function, it will add a listener as a side effect that will complete the external sign in when an end user is redirected back to your app. This works well in a single-page application but in a multi-page application, you might get redirected to a page that doesn't include the listener that was originally added as a side-effect. Hence you must include the specific OAuth listener on your login success page. | ||
|
||
</Accordion> | ||
- [Learn more about configuring the React Authenticator component for external providers](https://ui.docs.amplify.aws/react/connected-components/authenticator/configuration#external-providers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this filter have vue
and angular
even though the link is pointing to react
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The PR has the following changes:
InlineFilter
to hide not relevant content for SwiftInstructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)
HTML:
<a href="https://docs.amplify.aws/">link</a>
When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.