Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swift): Fixing Auth category for Gen2 #7576

Merged
merged 10 commits into from May 17, 2024
Merged

fix(swift): Fixing Auth category for Gen2 #7576

merged 10 commits into from May 17, 2024

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented May 11, 2024

Description of changes:

The PR has the following changes:

  • Adds missing Swift code snippets
  • Fix pages to add references for Swift authenticator.
  • Fix verbages for MFA
  • Add InlineFilter to hide not relevant content for Swift
  • Add missing pages

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested review from a team and josefaidt as code owners May 11, 2024 00:56
harsh62 and others added 3 commits May 13, 2024 10:25
…credentials/index.mdx

Co-authored-by: Sebastian Villena <97059974+ruisebas@users.noreply.github.com>
…d/using-the-authenticator/index.mdx

Co-authored-by: Sebastian Villena <97059974+ruisebas@users.noreply.github.com>
ruisebas
ruisebas previously approved these changes May 13, 2024
…d/sign-in/index.mdx

Co-authored-by: josef <josef.aidt@gmail.com>
@harsh62 harsh62 requested a review from josefaidt May 13, 2024 20:16
@timngyn timngyn self-requested a review May 15, 2024 16:49
When you import and use the `signInWithRedirect` function, it will add a listener as a side effect that will complete the external sign in when an end user is redirected back to your app. This works well in a single-page application but in a multi-page application, you might get redirected to a page that doesn't include the listener that was originally added as a side-effect. Hence you must include the specific OAuth listener on your login success page.

</Accordion>
- [Learn more about configuring the React Authenticator component for external providers](https://ui.docs.amplify.aws/react/connected-components/authenticator/configuration#external-providers)
Copy link
Member

@timngyn timngyn May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this filter have vue and angular even though the link is pointing to react?

@harsh62 harsh62 merged commit 504516b into main May 17, 2024
10 checks passed
@harsh62 harsh62 deleted the gen2-auth-doc-fix branch May 17, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants