New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React storage/cancel upload from process file #5179
base: main
Are you sure you want to change the base?
React storage/cancel upload from process file #5179
Conversation
+ add note about deleteing yarn.lock, so Cypress will download/install correctly + add `nvm install` & `nvm use` to react file.
🦋 Changeset detectedLatest commit: 92400ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@raystorm Thanks for opening this! Need to discuss with the team, will update here once we have next steps |
add changeset
…l-upload-from-processFile # Conflicts: # yarn.lock
@raystorm Just wanted to update you here, we are aligned with adding the update to |
@raystorm We recently made some updates to the |
* move ProcessFile Error/reject handling to `getInput()`
Merge Conflicts are resolved. You may want to run the test example from my branch locally, to make sure everything still works properly. The Error Handling code is the same, but moved to |
Description of changes
Adds support for the ability to cancel an Upload from
processFile()
by returning a rejected promise.
Issue #, if available
#5099
Description of how you validated changes
removeUpload()
is called when a rejected promise is returned fromprocessFile()
.Promise.reject()
in examples.ran the example manually with additional Logging code
(not committed, and now removed to watch/verify operation.)
Checklist
yarn test
passes and tests are updated/addedsideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.