Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @smithy/util-base64 #5066

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

chore: upgrade @smithy/util-base64 #5066

wants to merge 13 commits into from

Conversation

esauerbo
Copy link
Contributor

Description of changes

Upgrade ^2.0.0 to use 2.2.1, (latest version containing patch)

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@esauerbo esauerbo requested a review from a team as a code owner March 12, 2024 19:25
Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 16c69d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

reesscot
reesscot previously approved these changes Mar 12, 2024
Copy link
Contributor

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the aws sdk packages dep versions for liveness?

@esauerbo
Copy link
Contributor Author

Do we need to update the aws sdk packages dep versions for liveness?

I don't think so, because the "@smithy/util-base64@^2.0.0": is what the aws sdk packages reference, and that got updated to 2.2.1 @calebpollman

@aws-amplify/ui-react-liveness@3.0.13 -> ./packages/react-liveness
  ├─┬ @aws-sdk/client-rekognitionstreaming@3.398.0
  │ ├─┬ @aws-sdk/client-sts@3.398.0
  │ │ └── @smithy/util-base64@2.2.1 deduped
  │ ├─┬ @aws-sdk/credential-provider-node@3.398.0
  │ │ └─┬ @aws-sdk/credential-provider-sso@3.398.0
  │ │   ├─┬ @aws-sdk/client-sso@3.398.0
  │ │   │ └── @smithy/util-base64@2.2.1 deduped
  │ │   └─┬ @aws-sdk/token-providers@3.398.0
  │ │     └── @smithy/util-base64@2.2.1 deduped
  │ ├─┬ @smithy/fetch-http-handler@2.0.5
  │ │ └── @smithy/util-base64@2.2.1 deduped
  │ └── @smithy/util-base64@2.2.1
  └─┬ @smithy/fetch-http-handler@2.1.5
    └── @smithy/util-base64@2.2.1 deduped

@reesscot
Copy link
Contributor

I think for good measure, we might as well update @aws-sdk/client-rekognitionstreaming as well

Copy link
Contributor

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the following dep versions in the liveness package.json:

  • @aws-sdk/client-rekognitionstreaming
  • @aws-sdk/util-format-url
  • @smithy/eventstream-serde-browser
  • @smithy/fetch-http-handler
  • @smithy/protocol-http

reesscot
reesscot previously approved these changes Mar 12, 2024
"@smithy/eventstream-serde-browser": "^2.0.4",
"@smithy/fetch-http-handler": "^2.1.3",
"@smithy/protocol-http": "^3.0.3",
"@aws-sdk/client-rekognitionstreaming": "3.529.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we investigate what's happening here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants