Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ja.ts #5054

Merged
merged 7 commits into from May 14, 2024
Merged

Update ja.ts #5054

merged 7 commits into from May 14, 2024

Conversation

sj-h4
Copy link
Contributor

@sj-h4 sj-h4 commented Mar 10, 2024

Description of changes

In <authenticator>, 'Enter your Username' is used instead of 'Enter your username', so I added a Japanese translation for 'Enter your Username'.

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Add  upper case version: 'Enter your Username.
@sj-h4 sj-h4 requested a review from a team as a code owner March 10, 2024 09:12
Copy link

changeset-bot bot commented Mar 10, 2024

🦋 Changeset detected

Latest commit: 25a8033

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@aws-amplify/ui Patch
@aws-amplify/ui-react-auth Patch
@aws-amplify/ui-react-core-auth Patch
@aws-amplify/ui-react-core-notifications Patch
@aws-amplify/ui-react-core Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-native-auth Patch
@aws-amplify/ui-react-native Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-react Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch
@aws-amplify/ui-react-geo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@esauerbo esauerbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sj-h4 thank you for your contribution! Left a few comments.

@sj-h4
Copy link
Contributor Author

sj-h4 commented Mar 12, 2024

@esauerbo
Thank you for your review! I updated.

@zchenwei zchenwei added the run-tests Adding this label will trigger tests to run label May 14, 2024
@zchenwei zchenwei merged commit b92c34a into aws-amplify:main May 14, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request May 14, 2024
@sj-h4 sj-h4 deleted the add-ja-translation branch May 14, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-tests Adding this label will trigger tests to run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants