Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(liveness/no-light): move start api call to component mount #5044

Closed
wants to merge 6 commits into from

Conversation

esauerbo
Copy link
Contributor

@esauerbo esauerbo commented Mar 5, 2024

Description of changes

Moves the call to StartFaceLivenessSession (invoked by initializeLivenessStream) to the controlling component, FaceLivenessDetectorCore.

Old flow: Click "start video check", enter start state, detect face/distance, enter initializeLivenessStream
New flow: EnterinitializeLivenessStream, click "start video check", enter start state, detect face/distance

Since the state machine is initialized in FaceLivenessDetectorCore here, initializeLivenessStream is automatically invoked on the component mount.

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@esauerbo esauerbo requested a review from a team as a code owner March 5, 2024 22:13
Copy link

changeset-bot bot commented Mar 5, 2024

⚠️ No Changeset found

Latest commit: f338b3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@calebpollman calebpollman changed the base branch from nolight/main to liveness/no-lights March 15, 2024 17:13
@esauerbo esauerbo deleted the branch liveness/no-lights May 16, 2024 17:36
@esauerbo esauerbo closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant