Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix I18n demo screen bugs #1196

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Fix I18n demo screen bugs #1196

merged 1 commit into from
Jan 26, 2022

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented Jan 26, 2022

Issue #, if available:

Description of changes: This fixes https://ui.docs.amplify.aws/components/authenticator#labels--text that I broke again with #1168. Not a runtime error this time, but screens weren't rendering because its state machine was not initiated.

This PR ensures that LabelsAndTextDemo starts the state machine by explicitly sending INIT event.

Kapture.2022-01-26.at.12.00.38.mp4

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2022

⚠️ No Changeset found

Latest commit: 42a560b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wlee221 wlee221 requested a review from a team January 26, 2022 20:10
@wlee221 wlee221 enabled auto-merge (squash) January 26, 2022 20:12
@wlee221 wlee221 temporarily deployed to ci January 26, 2022 20:13 Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2022 20:13 Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2022 20:13 Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2022 20:13 Inactive
@reesscot
Copy link
Contributor

@wlee221 Can you please follow up this PR with an integration tests on this section of the docs.

@wlee221 wlee221 merged commit 13e3637 into main Jan 26, 2022
@wlee221 wlee221 deleted the send-init-event-from-demo branch January 26, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants