Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable
useAuthenticator
usage outside <Authenticator /> #1168Enable
useAuthenticator
usage outside <Authenticator /> #1168Changes from 13 commits
e0c4216
5d91efe
d0b9dd3
ccf4cc2
af70d1e
1e9b3d7
c361bb9
96ca00f
2231840
4dc50b4
3b5abb6
cbc1f07
104cd62
4ba6855
37e4f2c
9e71360
33a5e68
bf6105b
392ef6e
dc4e507
712b40e
e556d47
fbe623a
12a4d35
c4d9999
480d76f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try to make sure Vue works in the future here, with this new useAuthenticator feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I'll do one for Angular too. Let's do that on separate PRs though, in case there are
useAuthenticator
gotchas in other frameworks. (and tbh I'm scared I broke something this PR and have to revert it)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a follow up from #1162. We're setting
INIT
event after we get the necessarymachineProps
inAuthenticator
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useAuthenticator
now returns only contexts related toauth
!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assert this is not a breaking change because components were only used internally to emulate
Slot
functionality. There were no motives for customers to re-access custom components after they already passed in.And
useAuthenticator
was never documented in the first place.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this explanation!
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad you made this optional. Always bothered me you had to add
signOut
anduser
when usingauthenticator