chore: ask for consent for diagnose report #12710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/amplify-e2e-tests/src/__tests__/migration/api.connection.migration.test.ts
Fixed
Show fixed
Hide fixed
packages/amplify-e2e-tests/src/__tests__/migration/api.connection.migration2.test.ts
Fixed
Show fixed
Hide fixed
packages/amplify-e2e-tests/src/__tests__/migration/api.key.migration1.test.ts
Fixed
Show fixed
Hide fixed
packages/amplify-e2e-tests/src/__tests__/migration/api.key.migration3.test.ts
Fixed
Show fixed
Hide fixed
packages/amplify-e2e-tests/src/__tests__/migration/api.key.migration3.test.ts
Fixed
Show fixed
Hide fixed
packages/amplify-e2e-tests/src/__tests__/migration/api.key.migration5.test.ts
Fixed
Show fixed
Hide fixed
evcodes
commented
Jun 8, 2023
Comment on lines
40
to
44
| false, | ||
| false, | ||
| 0, | ||
| false, | ||
| true, |
There was a problem hiding this comment.
We should make a settings object within amplifyPushUpdate parameters.. I wrote this like this as a quick and dirty solution just to see if this would work.
| import { amplifyRegions } from '../configure'; | ||
| import { mergeDeploymentSecrets } from '@aws-amplify/amplify-cli-core'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
sobolk
requested changes
Jul 27, 2023
Comment on lines
+90
to
+99
| if (DebugConfig.Instance.promptSendReport()) { | ||
| const result = await prompter.yesOrNo('Help improve Amplify CLI by sharing non sensitive configurations on failures', false); | ||
| DebugConfig.Instance.setAndWriteShareProject(result); | ||
| if (result === false) { | ||
| return; | ||
| } | ||
| const diagnoseAction = await prompter.pick('What would you like to do?', choices); | ||
| if (diagnoseAction !== choices[0]) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
We should.
- Double check this condition with . I.e. we must never ask this question in headless mode.
- We should undo all the changes made to e2e/migration/other tests. They don't scale. Current implementation covers very narrow failure modes that are expected. All unexpected errors will now result in
nexpecttiming out on unexpected prompt should failure happen (transient or not). This will contribute to overall e2e test runtime. - Instead of that we should.
- Opt out existing e2e tests by default, i.e. make sure
DebugConfig.Instance.promptSendReport()returnsfalse, so this prompt is never asked there. - Add test(s) and test utils dedicated to covering that particular scenario.
- Opt out existing e2e tests by default, i.e. make sure
0618
reviewed
Aug 1, 2023
| if (diagnoseAction !== choices[0]) { | ||
| return; | ||
| if (DebugConfig.Instance.promptSendReport()) { | ||
| const result = await prompter.yesOrNo('Help improve Amplify CLI by sharing non sensitive configurations on failures', false); |
There was a problem hiding this comment.
Looks like we've already got a prompt on line 37, why do we need to add this line to zipSend again? https://github.com/aws-amplify/amplify-cli/pull/12710/files#diff-71cabcaa3379af3b9458f6802b25c65f6c00768606d5ef7f8c010094d8720aa1R37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously the CLI would ask permission for diagnose command on init but this PR moves the ask to the beginning of diagnose command. This is set on a per-project basis.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.