Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker labels #138

Closed
wants to merge 10 commits into from
Closed

Conversation

AhnSeongHyun
Copy link

Issue #, if available:

Description of changes:

  • Add docker-labels to optional action input(action.yml)
  • Apply docker-labes to ecs task definition dockerLabels.
  • Add test to empty case and update case.
  • Update README

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AhnSeongHyun AhnSeongHyun marked this pull request as ready for review November 26, 2021 03:44
@AhnSeongHyun
Copy link
Author

what is problem??

action.yml Outdated Show resolved Hide resolved
@v3rm0n
Copy link

v3rm0n commented Jun 20, 2023

Since AWS Fargate does not copy image labels to the containers, this change would be welcome. Otherwise it's pretty hard to add a git commit sha as a label to the container.

@justin1291
Copy link

Are there any issues with this? It would be a really useful feature.

@amazreech
Copy link
Contributor

amazreech commented May 10, 2024

Hi @AhnSeongHyun, thank you so much for your contribution. Apologies on the delay.
We will be working on reviewing this Pull Request. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please be sure to run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR if any.

@amazreech
Copy link
Contributor

This feature should be covered by PR 274.
Please feel free to re-open if the issue is not addressed.

@amazreech amazreech closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants