Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding zoom-fill #3917

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Stardust-kyun
Copy link

Added a zoom-fill example to the awful.wallpaper docs and replaced awful.wallpaper default to use zoom-fill in awesomerc.

@Stardust-kyun
Copy link
Author

I've also noticed that all of the maximized examples are written as "mazimized", with a z instead of an x -- is this intentional?

@actionless
Copy link
Member

actionless commented May 8, 2024

as "mazimized",

yeah clearly a typo

(changes in usage of wallpaper module in rc.lua)

i'll leave up the decision to @Elv13 who as far as i remember was designing the wallpaper module.
i personally think that result should be achieved by just using (or mb adding new) arguments, not manually pre-cropping the wallpaper straight in the rc.lua

@Elv13
Copy link
Member

Elv13 commented May 12, 2024

Hi,

Thanks for the extra doc example. Can you have just the example part as part of this PR? I am not really convinced why we would change the default. With this code, it relies on the current screen geometry (which might, sometime, change without this code being re-executed) and uses a rather low level helper function (which will confuse new users). I think those 2 things have side effects which might cause problem in some cases.

@Stardust-kyun
Copy link
Author

Thanks for the reply Elv! Reverted the change to the default. I figured that it would help new users to have it as the default since using zoom-fill for wallpapers is most common, and the default code can be misunderstood as such. However, I agree with your comments about its reliance on screen geometry and gears.surface. Pull should now be ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants