New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ocean indices branch: OSI, PI and FAI #52
Ocean indices branch: OSI, PI and FAI #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Please just update the DOI of OSI and it will be ready to be approved! ;)
src/indices.py
Outdated
short_name="OSI", | ||
long_name="Oil Spill Index", | ||
formula="(G + R)/B", | ||
reference="https://doi.org/10.29117/quarfe.2021.0020", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DOI is not working. Could you please update?
You are right, it is giving I suggest: Thanks :) |
I just checked. The first DOI is for the poster. In the poster the authors reference the new DOI you sent. I also checked the Conclusions and there it is the ratio. I think it's fine if we keep that last DOI and make the index available ;) Also, there are conflicts in |
Please confirm if everything is ready :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small error. I added a suggestion, you can commit it and it will be done! ;)
I realized I could commit it myself. I just did. |
Merged! The indices will be available in the new version of ASI. Thank you very much for your contribution! Cheers, David |
Added to the water domain: Oil Spill Index, Plastic Index, and Floating Algae Index.
PI spectral index is identical to IPVI, but the applications are different. I do not know how you handle these cases.
I added lambdaS1 because of FAI. This spectral index also uses lambdaR so I think it makes more sense to change the description of the lambdas. I changed the description to central wavelength in different files.
Tests OK.
Closes #50