Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocean indices branch: OSI, PI and FAI #52

Merged

Conversation

EmanuelCastanho
Copy link
Contributor

@EmanuelCastanho EmanuelCastanho commented May 4, 2024

Added to the water domain: Oil Spill Index, Plastic Index, and Floating Algae Index.

PI spectral index is identical to IPVI, but the applications are different. I do not know how you handle these cases.

I added lambdaS1 because of FAI. This spectral index also uses lambdaR so I think it makes more sense to change the description of the lambdas. I changed the description to central wavelength in different files.

Tests OK.

Closes #50

Copy link
Member

@davemlz davemlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Please just update the DOI of OSI and it will be ready to be approved! ;)

src/indices.py Outdated
short_name="OSI",
long_name="Oil Spill Index",
formula="(G + R)/B",
reference="https://doi.org/10.29117/quarfe.2021.0020",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DOI is not working. Could you please update?

@EmanuelCastanho
Copy link
Contributor Author

You are right, it is giving Error-Cannot Connect to Server. The DOI comes from ResearchGate.
There is this one https://doi.org/10.1016/j.mex.2021.101327, it is a paper from the same author, uses the same band ratios (see Conclusion), but does not explicitly mention OSI.

I suggest:
a) Using this different paper;
b) Commenting this index until the OSI DOI is back again.

Thanks :)

@davemlz
Copy link
Member

davemlz commented May 16, 2024

I just checked. The first DOI is for the poster. In the poster the authors reference the new DOI you sent. I also checked the Conclusions and there it is the ratio. I think it's fine if we keep that last DOI and make the index available ;)

Also, there are conflicts in indices.py, this is because new indices were just added, but not a major problem, just sync the branch ;)

@EmanuelCastanho
Copy link
Contributor Author

Please confirm if everything is ready :)

Copy link
Member

@davemlz davemlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small error. I added a suggestion, you can commit it and it will be done! ;)

src/indices.py Show resolved Hide resolved
@davemlz
Copy link
Member

davemlz commented May 16, 2024

I realized I could commit it myself. I just did.

@davemlz davemlz merged commit e6a3a7d into awesome-spectral-indices:main May 16, 2024
1 check passed
@davemlz
Copy link
Member

davemlz commented May 16, 2024

Merged!

The indices will be available in the new version of ASI. Thank you very much for your contribution!

Cheers,

David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about application domain and equation parameters
2 participants