Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GrDVI, LCN, MSAVI2 #49

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

j-miszczyszyn
Copy link

I decided to add several indicators but, despite reading the guide, I did not know how to proceed when adding more than one indicator. So I created a new branch and each separate commit is a new indicator.
I hope it works, I really appreciate the repository.
I work in R and admit that I had a problem running the test because i'm begginer in python.

I send warm regards,
Jakub

@davemlz
Copy link
Member

davemlz commented Apr 8, 2024

Don't worry, please follow this:

  • Update your branch, as it is outdated now. You can do this in the page of your branch: "Sync Branch".
  • Multiple indices in one PR are okay!
  • Delete LAI as LAI is not an spectral index.
  • The GDVI paper you mention (Tucker et al., 1979) doesn't mention the formula you propose. Please update the reference of this index. Additionally, try a different key for this index, it shouldn't be too long, e.g. "GrDVI".
  • The MSAVI2 paper you mention (Tucker, 1979) doesn't mention the formula you propose. Please update the reference of this index.
  • The LCN paper you mention (Boegh et al., 2002) doesn't mention the formula you propose. Please update the reference of this index.

If you are having issues with doing the PR, remember that you can also submit the request as an Issue ;)

Cheers!

@davemlz davemlz added NEW INDEX New spectral index original source required The original source of the index is not confirmed. labels Apr 8, 2024
@davemlz davemlz changed the title J miszczyszyn new indicates Add GrDVI, LCN, MSAVI2 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEW INDEX New spectral index original source required The original source of the index is not confirmed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants