Twin Implementation #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krantik
reviewed
Jan 2, 2024
iotconnect-sdk/include/iotconnect.h
Outdated
| typedef struct { | ||
| char *env; // Environment name. Contact your representative for details. | ||
| char *cpid; // Settings -> Company Profile. | ||
| char *duid; // Name of the device. | ||
| IotclOtaCallback ota_cb; // callback for OTA events. | ||
| IotclCommandCallback cmd_cb; // callback for command events. | ||
| IotcltwinrecivCallback twin_msg_rciv; |
There was a problem hiding this comment.
Can the same naming conventions as the other callback be followed?
There was a problem hiding this comment.
updated in the above latest commit.
krantik
reviewed
Jan 2, 2024
| printk("Error: no mqtt data_cb configured\n"); | ||
| printk("Error: no mqtt data_cb configured\n"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can this be properly indented to avoid confusion of the double braces back to back.
There was a problem hiding this comment.
updated in the above latest commit.
krantik
reviewed
Jan 2, 2024
samples/iotc-basic/src/main.c
Outdated
| @@ -19,7 +19,7 @@ | |||
| #include "led_pwm.h" | |||
| #else | |||
| #define ui_leds_init() | |||
| #define ui_led_set_rgb(a,b,c) (void) (a,b,c) | |||
| #define ui_led_set_rgb(a,b,c) | |||
There was a problem hiding this comment.
updated in the above latest commit.
There was a problem hiding this comment.
#define ui_led_set_rgb(a,b,c) was left since i used it from releases https://github.com/avnet-iotconnect/iotc-nrf-sdk/releases/tag/v2.0.0 "v2.0.0".
krantik
requested changes
Jan 2, 2024
|
@sw-ms-imranbhadelia Could you please take up the review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[scripts/setup-iotc-c-lib.sh ]
git clone --depth 1 --branch iotc-c-lib-patch https://github.com/avnet-iotconnect/iotc-c-lib.git
added git clone repo along with change in branch as it has the wrong url as well
[**iotconnect_event.h ** ] Twin Update
Declare the twin callback and process the iotcl_process_twin_event().
[iotc-c-lib-patch](avnet-iotconnect/iotc-c-lib@55faa28)
[ iotconnect_event.c] Twin Update
Defined the twin callback and processed the iotcl_process_twin_event() for reporting the value.
[iotc-c-lib-patch](avnet-iotconnect/iotc-c-lib@55faa28)
[samples/iotc-sensors-gps/src/main.c & samples/iotc-basic/src/main.c ]
Added Twin update callback
config->twin_msg_cb = on_twin_command;
static void on_twin_command(IotclEventData payload)
[ otconnect-sdk/src/iotconnect.c]
Added Twin static topic requires update and report the twin value
at defined iotc_twin_mqtt_data() where SDK will receive the twin payload.
iotconnect_update_twin() method to report the updated value coming from firmware.
[ iotconnect-sdk/include/iotconnect.h]
Declare twin call back in IotconnectClientConfig structure.
[iotconnect-sdk/nrf-layer-lib/src/iotconnect_mqtt.c ]
Along with the event topic twin payload is going to be identified
[iotconnect-sdk/nrf-layer-lib/include/iotconnect_mqtt.h ]
Declare twin call back under IotconnectMqttConfig structure.
@imran Please take a look at the changes.