Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FRC Colors integration to v2 bubble chart #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonahsnider
Copy link
Contributor

Congrats on the v2 release!

This PR adds the FRC Colors integration to the v2 bubble chart component. By default, colors are set to disabled, and can be enabled with a switch. Colors are hidden if their contrast ratio with the background is too low. This accounts for light/dark themes. There is no longer a limit on how many teams can be queried at once.

lDark mode screenshot
Light mode screenshot

Copy link

vercel bot commented Feb 21, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @avgupta456 on Vercel.

@avgupta456 first needs to authorize it.

@avgupta456
Copy link
Owner

Thanks for the PR! The Statbotics API that the new frontend subscribes to actually has a primary_color and secondary_color fields from FRC Colors to reduce website network requests (also reduces queries to TBA, Chezy Arena, etc.)

I need to do some more work to expose the primary and secondary colors in the website through the data context. I'll put this PR on hold until I do that (and probably the team, event, and match pages). For what it's worth, I think most people will use the V1 website until these features are complete anyways.

@jonahsnider
Copy link
Contributor Author

Ah, got it, thanks for the info. Feel free to adapt any parts of the PR you think would be useful once the colors are exposed from the Statbotics end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants