Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference forked migrate package. #1774

Closed
wants to merge 1 commit into from
Closed

Reference forked migrate package. #1774

wants to merge 1 commit into from

Conversation

dhui
Copy link

@dhui dhui commented Jan 26, 2018 •
edited

Old repo is no longer maintained: mattes/migrate#311
Addresses: golang-migrate/migrate#5

@jtemporal
Copy link
Contributor

Great to see that you are continuing migrate but I would only merge this once the organization is "more populated" as mentioned here and the coverage increases. Today's coverage doesn't meet the quality standards on our contributing guide:

Tests, where practical. If the library/program is testable, then coverage should be >= 80% for non-data-related packages and >=90% for data related packages.

@avelino
Copy link
Owner

avelino commented Feb 4, 2018

It is necessary to await the official decision of the @mattes

@avelino avelino closed this Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs tests pending-submitter-response quality standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dhui @jtemporal @avelino @cassiobotaro @kirillDanshin