Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove unused <depend> in package.xml files #177

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VRichardJP
Copy link
Contributor

see autowarefoundation/autoware#3468
To merge after all others package cleaning PR (to avoid missing deps downstream)

Description

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e91c5f7) 11.12% compared to head (c0d5151) 11.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   11.12%   11.12%           
=======================================
  Files          33       33           
  Lines        2436     2436           
  Branches     1288     1288           
=======================================
  Hits          271      271           
  Misses       1720     1720           
  Partials      445      445           
Flag Coverage Δ *Carryforward flag
differential 11.12% <ø> (?)
total 11.12% <ø> (ø) Carriedforward from e91c5f7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VRichardJP VRichardJP changed the title build: clean unused package.xml build: remove unused <depend> in package.xml files May 3, 2023
@VRichardJP VRichardJP force-pushed the clean_package_xml branch 2 times, most recently from 4f56167 to b5a492c Compare May 9, 2023 02:28
see autowarefoundation/autoware#3468

Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
Signed-off-by: Vincent Richard <richard-v@macnica.co.jp>
@stale
Copy link

stale bot commented Jul 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant